Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update babel #370

Merged
merged 4 commits into from
Jul 18, 2022
Merged

feat(android): update babel #370

merged 4 commits into from
Jul 18, 2022

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 15, 2022

  • update babel

Since v7.8.0 it should support optional chaining by default.

Test

const o = { a: { } };
console.log(o?.a);
console.log(o?.a?.b);
console.log(o?.a?.b ?? 'should be printed');

@m1ga
Copy link
Contributor Author

m1ga commented Jul 15, 2022

Tested the artifact with hyperloop-examples: build fine and works 👍

some other hl test projects work fine too.

const o = { a: { } };
console.log(o?.a);
console.log(o?.a?.b);
console.log(o?.a?.b ?? 'should be printed');

compiles and outputs

[INFO]  {}
[INFO]  undefined
[INFO]  should be printed

Copy link
Contributor

@caspahouzer caspahouzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caspahouzer caspahouzer merged commit 3bbf1d8 into tidev:master Jul 18, 2022
@m1ga m1ga deleted the babelUpdate branch December 25, 2023 14:02
@m1ga m1ga mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants