Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24811] LiveView causes multiple instances of same module when … #108

Merged
merged 3 commits into from
Sep 7, 2017

Conversation

feons
Copy link
Contributor

@feons feons commented Sep 6, 2017

…requiring using different paths

https://jira.appcelerator.org/browse/TIMOB-24811

Note:
This fixed the module caching issue, but I'm not able to catch the error from Ti.Network.createHTTPClient. Not sure why it's throwing an exception on Android, looks like something should be handled by the sdk https://jira.appcelerator.org/browse/TIMOB-25241. For iOS error is returned to the event handler.

[ERROR] TiHTTPClient: (TiHttpClient-10) [1,1123] HTTP Error (java.io.IOException): 404 : Not Found
[ERROR] TiHTTPClient: java.io.IOException: 404 : Not Found
[ERROR] TiHTTPClient: 	at ti.modules.titanium.network.TiHTTPClient$ClientRunnable.run(TiHTTPClient.java:1283)
[ERROR] TiHTTPClient: 	at java.lang.Thread.run(Thread.java:761)

@feons feons requested a review from ssekhri September 6, 2017 20:25
@ssekhri
Copy link

ssekhri commented Sep 7, 2017

@feons the module caching issue is fixed and works fine on both Android and iOS. However need to fix the exception being thrown on Android in order to close https://jira.appcelerator.org/browse/TIMOB-24811

Copy link

@ssekhri ssekhri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed. The module caching issue is resolved on both Android and iOS platform.
The tests as mentioned in the ticket work fine on both platforms.

@feons
Copy link
Contributor Author

feons commented Sep 7, 2017

Approved.

@feons feons merged commit 713d920 into tidev:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants