Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TIMOB-17181 LiveView: build fails when installing on a different device/... #80

Merged
merged 2 commits into from
Jun 26, 2014
Merged

TIMOB-17181 LiveView: build fails when installing on a different device/... #80

merged 2 commits into from
Jun 26, 2014

Conversation

pinnamur
Copy link
Contributor

We are initially starting the liveview server in the end or error events of the http.get call. However, seems that the http.get() call does not always end up in either of those events. The more consistent event we can rely on is the 'close' event after the http.get() call.

So, we are starting the liveview server after the existing servers are requested to kill. So, we can handle the timing issues on Windows and at the same time, it is more consistent that we will definitely end up starting up the liveview server each time.

Also, when there is a request to kill the existing running server, we should trigger the 'end' event before the socket/server are closed. This will help the clients to continuously keep on attempting to connect to the liveview servers, instead of just failing with error saying that server is unreachable.

@cb1kenobi
Copy link
Contributor

Tested, reviewed, and APPROVED!

cb1kenobi added a commit that referenced this pull request Jun 26, 2014
TIMOB-17181 LiveView: build fails when installing on a different device/...
@cb1kenobi cb1kenobi merged commit 40339b2 into tidev:master Jun 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants