Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23790] Fixed bug when stopping log relaying. #21

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Conversation

cb1kenobi
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-23790

  • Fixed bug when stopping log relaying.
  • Also fixed bug where an exception was not being caught. It needed to be caught and emitted as a V8 exception.
  • The exception was due to failing to start a service which in turn was because it detected the device over both USB and Wifi. Added code to ignore Wifi devices since we can't start services over Wifi.
  • Fixed bug with disconnecting from a device that has had more than one active connections.

Also fixed bug where an exception was not being caught. It needed to be caught and emitted as a V8 exception.

The exception was due to failing to start a service which in turn was because it detected the device over both USB and Wifi. Added code to ignore Wifi devices since we can't start services over Wifi.

Fixed bug with disconnecting from a device that has had more than one active connections.
@cb1kenobi
Copy link
Contributor Author

APPROVED!

@cb1kenobi cb1kenobi merged commit 5ef8662 into master Aug 18, 2016
@cb1kenobi cb1kenobi deleted the timob-23790 branch August 18, 2016 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant