[MOD-2182] Update Ti.Admob to work with iOS 8+, update iOS SDK to 7.6.0 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansemannn
changed the title
|
Thanks @stephenfeather! Just corrected the typo, the module should be good to go now. |
Closed
| - source install.sh | ||
| script: | ||
| - curl -o install.sh https://raw.githubusercontent.com/appcelerator-modules/ci/master/travis/install.sh #change this to appcelerator-modules once PR has been merged | ||
| - source install.sh -s "--branch 5_1_X" |
There was a problem hiding this comment.
Shouldn't we install the 5_2_X instead ? As ones its merged it will go in to 5_2_X
There was a problem hiding this comment.
It's the CI script, which needs to cover the minimum SDK version the module requires (which is 5.1.0)
|
FT and CR approved looks good, thanks Hans! |
AngelkPetkov
added a commit
that referenced
this pull request
Jan 28, 2016
[MOD-2182] Update Ti.Admob to work with iOS 8+, update iOS SDK to 7.6.0
This was referenced Jan 29, 2016
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/MOD-2182