[TIMOB-20604] Refactor iOS module #41
Conversation
# Conflicts: # android/manifest
…into TIMOB-24113 # Conflicts: # .travis.yml # android/manifest # android/timodule.xml # ios/manifest
apidoc/geofence.yml
Outdated
| @@ -44,7 +44,7 @@ description: | | |||
| for the [enterregions](Modules.Geofence.enterregions) or [exitregions](Modules.Geofence.exitregions) events, respectively. | |||
| For example: | |||
|
|
|||
| Geofence.addEventListener("enterregion", function(e) { | |||
| Geofence.addEventListener('enterregion', function(e) { | |||
There was a problem hiding this comment.
Please change 'enterregion' to 'enterregions' as 'enterregions' is the event name.
apidoc/geofence.yml
Outdated
| @@ -44,7 +44,7 @@ description: | | |||
| for the [enterregions](Modules.Geofence.enterregions) or [exitregions](Modules.Geofence.exitregions) events, respectively. | |||
| For example: | |||
|
|
|||
| Geofence.addEventListener("enterregion", function(e) { | |||
| Geofence.addEventListener('enterregions', function(e) { | |||
There was a problem hiding this comment.
- Before start monitoring region, we have request location permission. This is not mentioned in document. I have mentioned with example in comment of the ticket. Can you add same in document ?
- Please update examples mentioned in module. There are iOS7 related stuff there. And need to add location permission.
There was a problem hiding this comment.
Examples updated!
.travis.yml
Outdated
| env: | ||
| global: | ||
| - "MODULE_NAME=ti.geofence" | ||
| - TRAVIS_NODE_VERSION="4" | ||
| - TRAVIS_NODE_VERSION="8" |
There was a problem hiding this comment.
I am seeing jerkin is not able to build this and giving error -
"ERROR: appc requires Node.js >=8.0.0"
Is TRAVIS_NODE_VERSION is cause of this error?
There was a problem hiding this comment.
We need to remove Travis completely, which is now done.
|
@vijaysingh-axway @garymathews Also updated the play-services related docs that haven't been updated when including the ti.playservices dependency |
|
FR Passed. Location is correctly tracked and I receive enter and exit location events while monitoring regions. Tested using the provided samples as well as the geolocation/geofence suite |
JIRA: https://jira.appcelerator.org/browse/TIMOB-20604