Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android)(8_0_X): allow TiDownloadManager to use TiSocketFactory #10588

Merged
merged 4 commits into from
Mar 7, 2019
Merged

fix(android)(8_0_X): allow TiDownloadManager to use TiSocketFactory #10588

merged 4 commits into from
Mar 7, 2019

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews added this to the 8.0.0 milestone Jan 8, 2019
@build build requested a review from a team January 9, 2019 00:46
@build
Copy link
Contributor

build commented Jan 9, 2019 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.
📖

✅ All tests are passing
Nice one! All 2991 tests are passing.

Generated by 🚫 dangerJS against 79f7a3c

@sgtcoolguy sgtcoolguy modified the milestones: 8.0.0, 8.0.1 Jan 10, 2019
@keerthi1032
Copy link
Contributor

keerthi1032 commented Mar 7, 2019 •
edited

FR passed. image loads as expected.
Test Enviornment:
Operating System
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Memory = 17179869184
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local sdk 8.0.0.v20190109135904
Device =Samsung s5 android 6,samung android 4.4.2
Emulator =NEXUS 4.4,pixel android 9.

@keerthi1032 keerthi1032 merged commit 548dcbc into tidev:8_0_X Mar 7, 2019
@keerthi1032
Copy link
Contributor

PR merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
8.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @keerthi1032 @sgtcoolguy