Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_0_X): update aps-analytics.jar #10642

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

garymathews
Copy link
Contributor

@build
Copy link
Contributor

build commented Jan 23, 2019

Messages
📖

💾 Here's the generated SDK zipfile.

📖

✅ All tests are passing
Nice one! All 2990 tests are passing.

Generated by 🚫 dangerJS against 6fc1bc1

@longton95 longton95 self-requested a review January 23, 2019 13:39
Copy link
Contributor

@longton95 longton95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed

Verified using the test case below, events with accents are now present in the events tab

ENV

One Plus 6T (9.0)
Emulator (9.0, 6.0)
Appc NPM: 4.2.13
Appc CLI: 7.0.9
Ti CLI: 5.1.1
Node: 8.12.0
NPM: 6.4.1

app.js

const win = Titanium.UI.createWindow({
    backgroundColor: 'gray',
    layout: 'vertical'
});

const featureEventButton = Ti.UI.createButton({
    title: ' featureevent',
    top: 10
});
featureEventButton.addEventListener('click', function () {
    Ti.Analytics.featureEvent('feature.Event', {
        'featureEventValue': 'featureEventKey'
    });
});

const accentFeatureEventButton = Ti.UI.createButton({
    title: ' accentfeatureevent',
    top: 10
});
accentFeatureEventButton.addEventListener('click', function () {
    Ti.Analytics.featureEvent('featureEvent', {
        'féátúréEvéntVálúé': 'féátúréEvéntKéy'
    });
});
win.add(featureEventButton);
win.add(accentFeatureEventButton);
win.open();

@longton95 longton95 merged commit 5831b9f into tidev:8_0_X Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants