-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android)(8_1_X): call WebView.stopLoading() from main thread #11171
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have a different code pattern for dispatching method calls to happen on the main thread? (like a public
handleMessage()
method with a switch statement)?Also, is this the only call that needs to happen on the ui thread? What about
goForward()
,goBack()
, etc?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What Gary is solving is not thread related. He is doing the equivalent of a JS
setTimeout(function, 0)
. He's posting a runnable to the end of the event queue, which is something you may to do if the method is being called from the same object's callback (ie: you need to unwind the stack before performing the action). I can see this being an issue with theonlink
callback since it needs immediately feedback before loading a URL. Although I wouldn't think ourWebView
events would have this problem since they're queued and not invoked immediately.I too am curious regarding
goForward()
,goBack()
, and other APIs.Regarding
Handler
, I'd prefer that we use it for cases like this. It's simpler and it's what most native Android devs use.handleMessage()
is more complicated and error prone (message ID collision has happened in our code in the past) and its only real advantage is that it allows inherited classes to override the handling of received message, which isn't applicable here.Side Note:
Gary, you don't need to create a new main handler here. There is a
View.getHandler()
method that you can use instead.https://developer.android.com/reference/android/view/View#getHandler()