Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_2_X): performance issue with deeply nested views as of 7.5.0 #11254

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway added this to the 8.2.1 milestone Oct 2, 2019
@build build requested a review from a team October 2, 2019 03:16
@build
Copy link
Contributor

build commented Oct 2, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

📖 ❌ 2 tests have failed There are 2 tests failing and 471 skipped out of 4336 total tests.
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientcallbackTestForGETMethod1.352
Error: 404 : Not Found
at HTTPClient.xhr.onerror (/ti.network.httpclient.test.js:409:16)
android.emulator.Titanium.UI.NavigationWindowbasic open/close navigation45.852
Error: timeout of 10000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:4326:18)

Generated by 🚫 dangerJS against b9ede74

@lokeshchdhry
Copy link
Contributor

FR Passed.

Tested with info in the master PR.

Studio Ver: 5.1.4.201909061933
SDK Ver: 8.2.1 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.0
Appc NPM: 4.2.15
Appc CLI: 7.1.1
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.1
Alloy Ver: 1.14.1
Node Ver: 10.16.1
NPM Ver: 6.9.0
Java Ver: 10.0.2
Android Devices: ⇨ google Pixel (Android 9)
Emulator: Android 6.0

@sgtcoolguy sgtcoolguy merged commit 38dc352 into tidev:8_2_X Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants