Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android)(8_3_X): amend load app info order #11337

Merged
merged 2 commits into from
Nov 15, 2019

Conversation

garymathews
Copy link
Contributor

  • Amend appInfo loading to satisfy appc-remote-encryption-policy
TEST CASE
tiapp.xml
<property name="appc-sourcecode-encryption-policy">remote</property>
appc run -p android -D test
  • Application should run without issues

JIRA Ticket

@build build added this to the 8.3.0 milestone Nov 14, 2019
@build build requested a review from a team November 14, 2019 23:31
@build
Copy link
Contributor

build commented Nov 14, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 👍 Hey!, You deleted more code than you added. That's awesome!
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 710 skipped out of 7334 total tests.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientclearCookieUnaffectedCheck60.05
Error: timeout of 60000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)
android.emulator.Titanium.UI.Android.ProgressIndicatordialog determinant - min: 0, max: 1009.365
Error: timeout of 5000ms exceeded
at Titanium.<anonymous> (/ti-mocha.js:6535:53723)

Generated by 🚫 dangerJS against a479d03

@lokeshchdhry
Copy link
Contributor

FR Passed.

No errors seen when using remote encryption.

Studio Ver: 5.1.4.201909061933
SDK Ver: 8.3.0 local build
OS Ver: 10.14.5
Xcode Ver: Xcode 11.2.1
Appc NPM: 4.2.15
Appc CLI: 7.1.2-master.5
Daemon Ver: 1.1.3
Ti CLI Ver: 5.2.2
Alloy Ver: 1.14.2
Node Ver: 10.17.0
NPM Ver: 6.11.3
Java Ver: 10.0.2
Android Devices: ⇨ google Pixel (Android 9)
Android Emulator: Android 6.0

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@sgtcoolguy sgtcoolguy merged commit 95d4c18 into tidev:8_3_X Nov 15, 2019
sgtcoolguy pushed a commit that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants