Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android/ios)(9_0_X): amend Tab tintColor and activeTintColor #11741

Merged
merged 30 commits into from
Jun 8, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented May 29, 2020

@tidev tidev deleted a comment from build May 29, 2020
@build
Copy link
Contributor

build commented May 29, 2020

Messages
📖

💾 Here's the generated SDK zipfile.

📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖

✅ All tests are passing
Nice one! All 6582 tests are passing.
(There are 695 skipped tests not included in that total)

Generated by 🚫 dangerJS against 2602823

@build build added this to the 9.0.3 milestone Jun 4, 2020
Copy link
Contributor

@ssjsamir ssjsamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FR Passed: Tested with the test case above, able to see the tint colours on titles and icons.

Test Environment

MacOS Catalina: 10.15.5 Beta
Xcode: 11.4
Java Version: 1.8.0_131
Android NDK: 21.1.6273396-beta2
Node.js: 10.16.3
""NPM":"5.0.0","CLI":"8.0.0""
Andoird Pixl xl 7.1.1 Emulator 
iphone 8 13.4 sim

@sgtcoolguy sgtcoolguy merged commit c8ddecd into tidev:9_0_X Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants