Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): allow string-based "verticalAlign" in Ti.UI.Label #12566

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-28391

Example:

const win = Ti.UI.createWindow({
    backgroundColor: '#fff'
});
 
const view = Ti.UI.createView({
    backgroundColor: '#f0f0f0',
    height: 200,
    width: 200
});
 
view.add(Ti.UI.createLabel({
    text: 'Hello world',
    verticalAlign: 'top',
    height: Ti.UI.FILL,
    width: Ti.UI.FILL
}));
 
win.add(view);
win.open();

@build build added this to the 10.1.0 milestone Mar 13, 2021
@build build requested review from a team March 13, 2021 11:10
@build
Copy link
Contributor

build commented Mar 13, 2021

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ✊ The commits in this PR match our conventions! Feel free to Rebase and Merge this PR when ready.
📖 ❌ 2 tests have failed There are 2 tests failing and 960 skipped out of 15407 total tests.
📖 🎉 Another contribution from our awesome community member, hansemannn! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

ClassnameNameTimeError
android.emulator.Titanium.Network.HTTPClientTIMOB-19042 (5.0.2)0.164
Error: expected 502 to equal 404
at Assertion.fail (/node_modules/should/cjs/should.js:275:13)
      at Assertion.value (/node_modules/should/cjs/should.js:356:9)
      at HTTPClient.xhr.onerror (/ti.network.httpclient.test.js:124:16)
ios.macos.Titanium.Media.properties.audioPlaying is a Boolean (10.15.5)29.081
Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (app.js)
run@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12566/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9258:22
processImmediateQueue@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12566/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9321:18
drainQueues@file:///Users/build/jenkins/workspace/ium-sdk_titanium_mobile_PR-12566/tmp/mocha/build/iphone/build/Products/Debug-maccatalyst/mocha.app/Contents/Resources/ti.main.js:9298:52

Generated by 🚫 dangerJS against 6a69293

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lokeshchdhry
Copy link
Contributor

FR Passed.

@ewanharris ewanharris merged commit 9363c42 into tidev:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants