Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update internal libraries #13346

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Mar 29, 2022

@hansemannn
Copy link
Collaborator

Funny - I thought the same: https://github.com/tidev/titanium_mobile/compare/master...hansemannn:fix/update-android-core-libs?expand=1

We should definitely upgrade these.

@hansemannn
Copy link
Collaborator

From what I see, it's save to integrate. The build is passing, the upgrades are mainly minor semver patches and the app still works fine. I just wonder if the play services update should be delayed a bit, since I can remember how cautious @jquick-axway was when updating it due to common bugs that are fixed in later versions.

@m1ga
Copy link
Contributor Author

m1ga commented Mar 31, 2022

I was using this ti.playerservice version 18.0.1 in some test apps already. But I can lower that version again to be safe

@jquick-axway
Copy link
Contributor

I recommend that you build the "kitchensink-v2" and "hyperloop-examples" apps to see if this causes any breaking-changes. If those apps look fine, then these dependency updates are probably fine too. (Usually it is, but sometimes Google makes breaking-changes.)

@m1ga
Copy link
Contributor Author

m1ga commented Apr 1, 2022

Thanks @jquick-axway 👍
Hyperloop-examples and Kitchensink-v2 work and look fine with this PR. Tested with an Android 13 emulator

@hansemannn
Copy link
Collaborator

Ok, then do all proposed updates! We wil have a beta cycle anyway, so users will be able to test it before going GA. @m1ga Can you change the PR to "Ready for review"?

@m1ga m1ga marked this pull request as ready for review April 1, 2022 18:56
@hansemannn hansemannn merged commit 1325f1a into tidev:master Apr 2, 2022
@m1ga m1ga deleted the androidLibs branch May 23, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants