Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-7685:Android: HW window: view does not show on 3.x devices #1587

Merged
merged 1 commit into from
Mar 7, 2012
Merged

TIMOB-7685:Android: HW window: view does not show on 3.x devices #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions android/titanium/src/java/org/appcelerator/titanium/proxy/TiWindowProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
import android.graphics.PixelFormat;
import android.os.Build;
import android.os.Message;
import android.view.View;

@Kroll.proxy(propertyAccessors={
TiC.PROPERTY_EXIT_ON_CLOSE,
Expand Down Expand Up @@ -393,6 +394,14 @@ public void run() {
{
waitingForOpen = null;
}

View nativeView = view.getNativeView();

// Make sure we draw the view during the layout pass. This does not seem to cause another layout pass. We need
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the view isn't being drawn via any kind of google bug reports? Just curious if there is anymore background info.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been able to find any google bug on this.

What I found during my research: This code triggers a layout pass on the window layout, and is done before its children have gone through a layout pass. As a result, it doesn't trigger any additional layout passes.

// to force the view to be drawn due to TIMOB-7685
if (nativeView != null) {
nativeView.postInvalidate();
}
}

@Kroll.method
Expand Down