Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timob 9216 Swipe and Scrollableview parity update. #2308

Merged
merged 9 commits into from
Jun 2, 2012
Merged

Timob 9216 Swipe and Scrollableview parity update. #2308

merged 9 commits into from
Jun 2, 2012

Conversation

nebrius
Copy link
Contributor

@nebrius nebrius commented Jun 2, 2012

No description provided.

processTouchStartEvent: function(e, element){
if (e.touches.length == 1 && e.changedTouches.length == 1) {
this._distanceThresholdPassed = false;
this._touchStartLocation = {
x: e.changedTouches[0].clientX,
y: e.changedTouches[0].clientY
}
};
this._startTime = (new Date()).getTime();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parenthesis not needed after Date:

this._startTime = (new Date).getTime();

@nebrius
Copy link
Contributor Author

nebrius commented Jun 2, 2012

Comments addressed...mostly copy-paste errors or artifacts of moving code around.

@cb1kenobi
Copy link
Contributor

Code reviewed and tested. Request accepted.

cb1kenobi added a commit that referenced this pull request Jun 2, 2012
Timob 9216 Swipe and Scrollableview parity update.
@cb1kenobi cb1kenobi merged commit 7d646de into tidev:master Jun 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants