Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TIMOB-15263-3_1_X: Android: Modules will not compile with (latest) Android NDK r9. #4744

Merged
merged 2 commits into from
Sep 27, 2013
Merged

TIMOB-15263-3_1_X: Android: Modules will not compile with (latest) Android NDK r9. #4744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49ee7a1
TIMOB-15263: Android: Modules will not compile with (latest) Android …
matt-langston Sep 27, 2013
57cfd09
TIMOB-15263: Android: Modules will not compile with (latest) Android …
matt-langston Sep 27, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/runtime/v8/src/native/Android.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ include $(CLEAR_VARS)
include $(LOCAL_PATH)/genSources.mk
include $(LOCAL_PATH)/common.mk

# https://jira.appcelerator.org/browse/TIMOB-15263
LOCAL_DISABLE_FORMAT_STRING_CHECKS=true

LOCAL_MODULE := kroll-v8
LOCAL_CFLAGS := $(CFLAGS)
LOCAL_LDLIBS := $(LDLIBS)
Expand Down
3 changes: 3 additions & 0 deletions android/runtime/v8/src/ndk-modules/libv8/Android.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ include $(CLEAR_VARS)
V8_VERSION=3.9.24.29
LIBV8_DIR := ../../../../../../dist/android/libv8/$(V8_VERSION)

# https://jira.appcelerator.org/browse/TIMOB-15263
LOCAL_DISABLE_FORMAT_STRING_CHECKS=true

LIBV8 := libv8

ifeq ($(NDK_DEBUG),1)
Expand Down
3 changes: 3 additions & 0 deletions support/module/android/generated/Android.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ THIS_DIR = $(LOCAL_PATH)
LOCAL_MODULE := @MODULE_ID@
LOCAL_CFLAGS := -g "-I$(TI_MOBILE_SDK)/android/native/include"

# https://jira.appcelerator.org/browse/TIMOB-15263
LOCAL_DISABLE_FORMAT_STRING_CHECKS=true

# Several places in generated code we set some jvalues to NULL and
# since NDK r8b we'd get warnings about each one.
LOCAL_CFLAGS += -Wno-conversion-null
Expand Down