Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): update socket deps #164

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Apr 11, 2022

Update the socket.io library to 2.0.1 so it will be compatible with Socket.io 3/4: https://github.com/socketio/socket.io-client-java#compatibility

Updated binary: ti.socketio-android-4.0.0.zip

Tested with my demo project at https://github.com/m1ga/socket_io_demo

@hansemannn
Copy link
Contributor

@m1ga The build is still failing, which I don't see as a blocker, but maybe you can get it running?

@m1ga
Copy link
Contributor Author

m1ga commented Jul 20, 2022

Give me a sec. I'll fix the github action (old SDK + old node). Its the same as in the hyperloop repo: https://github.com/tidev/hyperloop.next/pull/371/files

done: #183

@m1ga m1ga requested a review from hansemannn July 30, 2022 14:25
android/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note regarding the new version. Once updated, you can merge it directly!

@hansemannn hansemannn merged commit ef1ef5e into tidev:master Jul 30, 2022
@m1ga
Copy link
Contributor Author

m1ga commented Jul 30, 2022

Updated binary: ti.socketio-android-4.0.0.zip

@hansemannn
Copy link
Contributor

Already built & attached 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants