Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
remove finish_glance and add nobs #597
Following up on #594, I wanted to see how much work it would be to replace
Testing locally is difficult for some reason, so I'm opening this WIP PR just to see how far I am to a clean change.
This PR does the following:
Travis gives us the OK.
There are two doc-related warnings which might have been introduced by this PR. I can't quite figure out how to make them disappear. Any tips would be much appreciated.
@alexpghayes Please let me know if there's anything you'd like me to improve.
Re the multiple
I think the first one is coming from the
Thanks for looking at this.
I’m not super familiar with roxygen2, so I guess my question is why the Rd file gets written with 2 value sections.
The return section you point to here is attached to the tidy method.
The return section (with evalRd) you point to here is attached to the glance method:
This seems like a similar setup to the one used in
But I don’t get a warning in that case.
More generally, I’m curious to know what is considered “proper” broom documenting style. For instance, the
Okay, so I'm definitely on grad student time and I apologize for that!
This is fantastic! Will you:
After that I'll merge!
cool cool. I did those two things and fixed some minor conflicts against master. Also removed lme4 and nlme4 which appear to have been deprecated.
Travis breaks, but two of their machines break and
Here's what the tests look like on my machine: https://gist.github.com/vincentarelbundock/dee3cb1dbb3634c442f595f3ddc39310