Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set mode in set_dependency() #269

Merged
merged 2 commits into from
Jan 3, 2024
Merged

set mode in set_dependency() #269

merged 2 commits into from
Jan 3, 2024

Conversation

EmilHvitfeldt
Copy link
Member

bug fix for tidymodels/tidymodels.org#45.

This caused the partykit classification model to think it needed censored

library(parsnip)
library(bonsai)
library(censored)

parsnip::get_model_env()$decision_tree_pkgs |>
  dplyr::filter(engine == "partykit", mode == "classification") |>
  dplyr::pull(pkg)
#> [[1]]
#> [1] "partykit" "bonsai"   "censored"

@EmilHvitfeldt
Copy link
Member Author

This PR should be expanded to the entire package not just this case

@hfrick
Copy link
Member

hfrick commented Jan 3, 2024

I checked the other engines, they were already declaring their mode 👍

@hfrick hfrick merged commit add5f0b into main Jan 3, 2024
9 checks passed
@hfrick hfrick deleted the use-mode-in-set_dependency branch January 3, 2024 19:28
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants