Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually adjust correlation limits in plots #27

Closed
drsimonj opened this issue Oct 27, 2016 · 3 comments
Closed

Manually adjust correlation limits in plots #27

drsimonj opened this issue Oct 27, 2016 · 3 comments
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement

Comments

@drsimonj
Copy link
Collaborator

Currently, network_plot() and rplot() limit the colours and alpha etc to -1 and 1. However, with the addition of operations, these limits can be escaped.

Furthermore, it might just be nice for users to adjust these limits to suit their own purpose.

Thanks to @jcberny for the suggestion.

@drsimonj drsimonj changed the title Feature required: manually adjust correlation limits in plots Manually adjust correlation limits in plots Nov 13, 2016
@drsimonj drsimonj added bug an unexpected problem or unintended behavior enhancement labels Nov 13, 2016
@topepo topepo added feature a feature request or enhancement and removed enhancement labels Apr 3, 2020
@thisisdaryn
Copy link
Collaborator

Hi,

Do you have an example use case?

If I understand correctly, the suggestion is to allow the user to show a range of correlations other than -1 to 1. I think that the issue of allowing users to change how the color scales are applied to the displayed values is interesting. I have questions about allowing users to choose the range of correlations to display.

My intuition is that removing the weakest correlations is the most useful use case of giving the user to a broad ability to choose the correlation limits. network_plot currently allows for small correlations to be removed from the plot using its min_cor argument. rplot can be potentially be made to do the same. rplot naturally de-emphasizes the smallest correlations.
Adding this feature would necessitate reconciling the new feature with the existing feature.

I think there's one problematic scenario in particular with user-supplied limits: the user chooses to show moderate correlations while ignoring weak and strong relationships. As a viewer of the plot, it seems weird that a plot might show correlations between 0.3 and 0.6 and then it would be left to the viewer to reason or guess whether the missing relationships are weaker (i.e.< 0.3) or stronger (i.e. >0.6) than the relationships shown.

-daryn

@juliasilge
Copy link
Member

Those are great points, @thisisdaryn. Let's close this issue and leave the plot limits as they are for now. We can revisit this issue in the future if users open new issues asking about this.

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants