-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forthcoming uwot release will add output UMAP row names #88
Comments
Thank you so much for the report @jlmelville! Our tests were being pretty strict in checking objects including those names, but the 3rd edition of testthat makes it easier to relax that testing. I tested locally using your current development version and I believe the changes in that PR should make all well. We can do a CRAN release of embed before your next CRAN release, which will avoid problems with reverse dependency checks on CRAN. We don't have an immediate need to release embed, but could probably do one fairly soon because there is nothing blocking it, right @topepo? |
Thank you for the swift action on this, much appreciated. |
@jlmelville The new version of embed is now on CRAN so you should in the clear now; let us know if you see any other problems when you run revdeps again. |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Hello, at some point I hope to release a new version of uwot (a dependency of this package) and it looks like it will cause some breakage here.
A new feature/bug fix (for jlmelville/uwot#81) means that any row names of the input data are now retained as the output embedding matrix row names. This has caused all UMAP-related unit tests to fail: based on my testing, the
direct_*
matrix outputs will have row names associated with them, but those from callingbake
andstep_umap
will not. Currently there is no critical bug fix or other time-sensitive issue driving the release, but I am not sure how to proceed to minimize the disruption to this package.FWIW the relevant output of
testthat
(with the current development release of uwot) is below.The text was updated successfully, but these errors were encountered: