Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate aliasses #181

Closed
wants to merge 2 commits into from
Closed

deprecate aliasses #181

wants to merge 2 commits into from

Conversation

richierocks
Copy link
Contributor

@richierocks richierocks commented Aug 21, 2018

To fix #180

Work in progress; do not merge.

@ismayc
Copy link
Collaborator

ismayc commented Aug 22, 2018

Will be shifting to get_p_value() instead. Could some suggestions be added in case the aliases are attempted to be used going forward? Essentially something like

Error: `p_value()` is now deprecated. Please use `get_p_value()` instead.

@richierocks
Copy link
Contributor Author

@ismayc I've made all the required fixes to use get_confidence_intervals() and get_p_value().

It uses base::.Deprecated() to give a standard warning if you try get_pvalue() or one of the other deprecated functions.

Warning message:
'get_pvalue' is deprecated.
Use 'get_p_value' instead.
See help("Deprecated")

There is a warning on the travis-ci build that I can't get to the bottom of. It claims that get_pvalue() is an undefined export.

Everything works fine on my local machine, so I'd be tempted to just merged then rebuild the documentation.

@richierocks
Copy link
Contributor Author

Hmm. I realized that this PR still thinks it is taking content from the master branch. I'll close this a and give you a new Pr using the work from the develop branch.

@richierocks richierocks closed this Sep 3, 2018
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the unnecessary function aliasses
2 participants