function src_sql uses deprecate_stop but tries to pass in always=TRUE

[rdenham]

The function src_sql consists of

function (subclass, con, ...) 
{
    lifecycle::deprecate_stop(when = "1.4.0", what = "src_sql()", 
        always = TRUE)
}

but lifecycle::deprecate_stop doesn't have the always argument, that is in deprecate_warn. Running this, you'll get:

> dbplyr::src_sql()
Error in lifecycle::deprecate_stop(when = "1.4.0", what = "src_sql()",  : 
  unused argument (always = TRUE)

This affected me when trying to use the CKANR package:

> ckanr::src_ckan("https://www.data.qld.gov.au/")
url: https://www.data.qld.gov.au/
Error in lifecycle::deprecate_stop(when = "1.4.0", what = "src_sql()",  : 
  unused argument (always = TRUE)

My session details:

> sessionInfo()
R version 4.3.3 (2024-02-29)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 22.04.4 LTS

Matrix products: default
BLAS/LAPACK: /usr/lib/x86_64-linux-gnu/openblas-pthread/libopenblasp-r0.3.20.so;  LAPACK version 3.10.0

locale:
 [1] LC_CTYPE=C.UTF-8       LC_NUMERIC=C           LC_TIME=C.UTF-8       
 [4] LC_COLLATE=C.UTF-8     LC_MONETARY=C.UTF-8    LC_MESSAGES=C.UTF-8   
 [7] LC_PAPER=C.UTF-8       LC_NAME=C              LC_ADDRESS=C          
[10] LC_TELEPHONE=C         LC_MEASUREMENT=C.UTF-8 LC_IDENTIFICATION=C   

time zone: Australia/Brisbane
tzcode source: system (glibc)

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

loaded via a namespace (and not attached):
 [1] utf8_1.2.4       R6_2.5.1         tidyselect_1.2.1 magrittr_2.0.3  
 [5] glue_1.7.0       tibble_3.2.1     pkgconfig_2.0.3  dplyr_1.1.4     
 [9] generics_0.1.3   lifecycle_1.0.4  cli_3.6.2        fansi_1.0.6     
[13] vctrs_0.6.5      DBI_1.2.2        compiler_4.3.3   pillar_1.9.0    
[17] rlang_1.1.3      dbplyr_2.5.0    

[rdenham]

of course the real issue (for me) is with ckanr, which should be modified to use updated dbplyr package.