Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate duplicate warning on joins #2739

Closed
hadley opened this issue May 3, 2017 · 0 comments
Closed

Eliminate duplicate warning on joins #2739

hadley opened this issue May 3, 2017 · 0 comments
Labels
bug an unexpected problem or unintended behavior

Comments

@hadley
Copy link
Member

hadley commented May 3, 2017

df1 <- tibble(a = 1:2)
df2 <- tibble(
  b = structure(1:2, foo = "bar"),
)

out <- left_join(df1, df2, by = c("a" = "b"))
#> Warning messages:
#> 1: Column `b`/`a` has different attributes on LHS and RHS of join 
#> 2: Column `a`/`b` has different attributes on LHS and RHS of join 

@krlmlr could you take a look at this? I'm not familiar enough with the join code to figure out what's happening, but it looks like DualVector is constructed twice, once with left and right flipped.

@hadley hadley added bug an unexpected problem or unintended behavior data frame labels May 3, 2017
krlmlr added a commit to krlmlr/dplyr that referenced this issue May 8, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jun 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant