initial internal code for a between for strings #2995 #3540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainfrancois
added
feature
|
We might be able to use |
|
If we had sort keys (#3044) it would be just a |
|
I'm going to close this for now. We'll revise a more generic between #3744 through vctrs in the 0.9.0 horizon. |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now this is a separate function internally but I feel like
betweenshould dispatch and deal with at leastREALSXP,STRSXP,INTSXPandRAWSXP.The string version uses a
VectorVisitorImpl<STRSXP>so that it can take advantage of itsgreaterandlessmethods.Wondering however if we could take advantage that the
vecinVectorVisitorImpl<STRSXP>is forced to be utf8, would we not have a way to compare two utf8 strings without having to go through the hoops ofCharacterVectorOrderer