Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve the call stack on error #5322

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Preserve the call stack on error #5322

merged 2 commits into from
Jul 7, 2020

Conversation

lionel-
Copy link
Member

@lionel- lionel- commented Jun 10, 2020

Closes #5308

@lionel-
Copy link
Member Author

lionel- commented Jun 23, 2020

This will mess up last_error() output (but not last_trace() output). Requires a fix for r-lib/rlang#851. I'll wait until then to merge.

@lionel- lionel- mentioned this pull request Jul 6, 2020
Closed
@romainfrancois
Copy link
Member

This fixes the baguette issue discussed in #5376, I'll start a revdep asap when we merge this @lionel-

@lionel- lionel- merged commit cf0c673 into tidyverse:master Jul 7, 2020
@lionel- lionel- deleted the fix-rethrow-call-stack branch July 7, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley hadley approved these changes

@romainfrancois romainfrancois romainfrancois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use 'recover' with dplyr 1.0.0. How to interactively debug?
3 participants
@lionel- @romainfrancois @hadley