Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on new print method #305

Closed
hadley opened this issue Sep 11, 2017 · 4 comments
Closed

Feedback on new print method #305

hadley opened this issue Sep 11, 2017 · 4 comments

Comments

@hadley
Copy link
Member

hadley commented Sep 11, 2017

I'll record my impression in this issue. No need to do anything for a while. Will need to be broken up into multiple issues across tibble and pillar.

  • I don't like the underline in the heading

  • The header and footer need to be style_subtle()

  • Could we make the col_types italic? I like this style in slides, but it may be because I have a custom font. Or maybe they should be coloured to provide a stronger visual break?

  • Why do T and F get different colours? It's a bit distracting

  • Row numbers could be even subtler. Or possibly even a different colour. Need to be visually distinct from the data.

@hadley
Copy link
Member Author

hadley commented Sep 12, 2017

Year in this table provides an interesting counter point to highlighting the left most digits - when they're all constant, it's actually the rightmost that need highlighting:

screen shot 2017-09-12 at 9 46 00 am

@krlmlr
Copy link
Member

krlmlr commented Sep 12, 2017

Same for e.g. lat/lon values that are restricted to a small area, etc.. I wonder if it's safe to infer the (un)importance of a digit from the subset that pillar sees. Maybe use a third color?

@hadley
Copy link
Member Author

hadley commented Sep 12, 2017

Maybe we could apply some heuristic if the numbers are the same order of magnitude, and the digits on the left are constant, highlight on the right?

@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants