Remove check for empty dots in complete

Fixes #390
tidyverse · Jan 7, 2018 · 9321b94 · 9321b94
1 parent 336144a
commit 9321b94
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # tidyr 0.7.2.9000
 
+* `complete(data)` now returns `data` rather than throwing an error (#390).
+
 * `separate()` now longer checks that `...` is empty, allowing methods to make
   use of it. This check was added in tidyr 0.4.0 (2016-02-02) to deprecate
   previous behaviour where `...` was passed to `strsplit()`.

diff --git a/R/complete.R b/R/complete.R
@@ -26,10 +26,6 @@
 #' # You can also choose to fill in missing values
 #' df %>% complete(group, nesting(item_id, item_name), fill = list(value1 = 0))
 complete <- function(data, ..., fill = list()) {
-  if (is_empty(exprs(...))) {
-    abort("Please supply variables to complete")
-  }
-
   UseMethod("complete")
 }
 #' @export

diff --git a/tests/testthat/test-complete.R b/tests/testthat/test-complete.R
@@ -1,5 +1,9 @@
 context("complete")
 
+test_that("complete with no variables returns data as is", {
+  expect_equal(complete(mtcars), mtcars)
+})
+
 test_that("basic invocation works", {
   df <- tibble(x = 1:2, y = 1:2, z = 3:4)
   out <- complete(df, x, y)