Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(robosense)!: combine Robosense ROS wrappers into a single node #147

Merged
merged 2 commits into from
May 24, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented May 14, 2024

PR Type

  • Improvement

Related Links

TIER IV INTERNAL LINK -- corresponding issue
TIER IV INTERNAL LINK -- detailed article

This PR depends on the following PR being merged first:

This PR fixes the following issues (for Robosense only):

Description

This PR combines the Driver, HW Interface and HW Monitor wrappers into one. For more info, refer to

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex marked this pull request as draft May 14, 2024 09:16
@mojomex mojomex changed the base branch from main to develop May 17, 2024 05:44
@mojomex mojomex force-pushed the single-node-refactor-robosense branch from 7422a89 to 3468ed5 Compare May 23, 2024 04:06
@mojomex mojomex marked this pull request as ready for review May 23, 2024 04:52
@drwnz drwnz requested review from mebasoglu and drwnz May 24, 2024 00:54
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Note #1: I have not been able to test on real sensors, and as we don't have any, if we merge this PR now then it would be good to request @mebasoglu to test the develop branch later.
Note #2: Function documentation needs some additions, but let's address in later PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants