Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pretty-print sensor configurations #172

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jun 27, 2024

PR Type

  • Improvement

Description

Sensor configurations were printed without any special formatting before, making it hard to quickly, at a glance, verify sensor settings.
This PR proposes printing configs in a prettier format. See the below table for comparisons.

Before After
Screenshot from 2024-06-27 16-57-20 Screenshot from 2024-06-27 16-48-51
Screenshot from 2024-06-27 16-49-26
Screenshot from 2024-06-27 16-57-34 Screenshot from 2024-06-27 16-49-51
Screenshot from 2024-06-27 16-50-16
Screenshot from 2024-06-27 16-50-38

Additionally,

  • output where there was no space after a colon has been corrected
  • imports have been cleaned up in the files I touched

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz June 27, 2024 08:02
@mojomex mojomex self-assigned this Jun 27, 2024
@mojomex mojomex changed the base branch from main to develop June 27, 2024 08:02
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, but as per first couple of suggestions let's use this as an opportunity to make the printouts a bit better (also fixing capitalizations like PTP).

<< ", ConfigurationVehicleWidth: " << arg.configuration_vehicle_width
<< ", ConfigurationVehicleHeight: " << arg.configuration_vehicle_height
<< ", ConfigurationVehicleWheelbase: " << arg.configuration_vehicle_wheelbase;
os << "ContinentalARS548SensorConfiguration:" << '\n';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
os << "ContinentalARS548SensorConfiguration:" << '\n';
os << "Continental ARS548 Sensor Configuration:" << '\n';

Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit 04c9a0b into tier4:develop Jul 5, 2024
9 of 10 checks passed
@mojomex mojomex deleted the more-readable-config-printing branch July 5, 2024 09:54
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants