Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add boost version requirements #175

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Jul 5, 2024

PR Type

  • Improvement

Description

When trying to install Nebula on Ubuntu 20.04 with manually built Humble, a lot of Boost compile errors were emitted for
big_float32_buf_t and load_little_u16 etc. which are only supported for Boost 1.74.0 and later. Add this requirement to the readme file to avoid trouble in the future.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from drwnz July 5, 2024 02:19
@mojomex mojomex self-assigned this Jul 5, 2024
Copy link
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drwnz drwnz merged commit fb9a28d into tier4:develop Jul 5, 2024
2 of 3 checks passed
@mojomex mojomex deleted the readme-boost-version branch July 5, 2024 05:46
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants