Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nebula_ros/launch): supply choices for sensor_model launch argument #189

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

mojomex
Copy link
Collaborator

@mojomex mojomex commented Sep 4, 2024

PR Type

  • Improvement

Description

Add all supported sensor models as choices for their respective launch file's sensor_model argument. This makes ROS 2 check if the model is spelled correctly at launch time, thus improving usability.

Review Procedure

Check if Nebula still launches, and if all sensor models are mentioned.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@mojomex mojomex requested a review from knzo25 September 4, 2024 11:47
@mojomex mojomex self-assigned this Sep 4, 2024
@mojomex mojomex mentioned this pull request Sep 4, 2024
5 tasks
Copy link
Collaborator

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mojomex mojomex merged commit 7b429cb into tier4:develop Sep 6, 2024
10 checks passed
@mojomex mojomex deleted the launch-sensor-model-enums branch September 6, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants