feat(velodyne_ros_wrapper): add profiling log to velodyne #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
@mojomex created profiling scripts in this PR: #37
Description
Thanks to @mojomex, it is easy to measure performance of the driver. However the necessary logging code wasn't added for Velodyne. I added the logging to
velodyne_decoder_ros_wrapper.cpp
so that it is possible to use existing scripts to mesure process time for also Velodyne lidars.Review Procedure
The only modification is on
velodyne_decoder_ros_wrapper.cpp
. I added logging code according tohesai_decoder_ros_wrapper.cpp
.After building the package, go to the
scripts
directory and run:Here is the result I got for
VLP16
andVLS128
:Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks