Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add ros_environment dependency #58

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Aug 25, 2023

PR Type

  • Bug Fix

Related Links

https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/5938935074/job/16104423980?pr=21

Description

When building in an isolated environment the ROS_DISTRO environment variable is only available if ros_environment is declared as a dependency in package.xml (see https://github.com/ros/ros_environment/blob/rolling/)

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
@esteve
Copy link
Contributor Author

esteve commented Aug 25, 2023

@amc-nu I don't have permissions to assign a reviewer for this PR, but could you have a look at these changes? The Debian packages builder is failing because ROS_DISTRO is not available at build time unless ros_environemnt is a dependency (see https://github.com/autowarefoundation/autoware-deb-packages/actions/runs/5938935074/job/16104423980?pr=21). Thanks.

@esteve
Copy link
Contributor Author

esteve commented Aug 25, 2023

@amc-nu pinging again, when I submitted the previous comment I tagged the wrong user.

@amc-nu amc-nu merged commit eb76d55 into tier4:main Aug 25, 2023
6 checks passed
@esteve esteve deleted the fix-dependencies branch August 25, 2023 12:01
@esteve
Copy link
Contributor Author

esteve commented Aug 25, 2023

@amc-nu thanks 🙂

@amc-nu
Copy link
Contributor

amc-nu commented Aug 25, 2023

Thanks @esteve
Looking forward to apt install ros-humble-autoware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants