GH#1102: Fix spelling errors #1103

jsoref · 2023-11-16T07:19:50Z

Product Version(s):
Calico (3.24, 3.24.2, 3.25, 3.26), Calico Enterprise (3.15, 3.16, 3.17, 3.18), and Calico Cloud (3.14.0, 3.16.0, 3.16.1, 3.17)

Issue:
#1102

Link to docs preview:

SME review:

An SME has approved this change.

DOCS review:

A member of the docs team has approved this change.

Additional information:

A couple of recently merged commits fixed spelling items that I ran across but didn't maintain table alignment. I personally don't care about alignment, but I had attempted to retain proper alignment and have thus retained the alignment corrections in this PR -- I've tagged those changes with distinct commit messages of whitespace: -- I'm more than happy to drop them.

Merge checklist:

Deploy preview inspected wherever changes were made
Build completed successfully
Test have passed

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2023-11-16T07:19:55Z

@tigera/docs

netlify · 2023-11-16T07:19:56Z

✅ Deploy Preview for calico-docs-preview-next ready!

Name	Link
🔨 Latest commit	`75895d3`
🔍 Latest deploy log	https://app.netlify.com/sites/calico-docs-preview-next/deploys/655639a7b6cc7b0008a4fd92
😎 Deploy Preview	https://deploy-preview-1103--calico-docs-preview-next.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 72 (🟢 up 15 from production) Accessibility: 93 (no change from production) Best Practices: 92 (no change from production) SEO: 79 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-11-16T07:19:58Z

👷 Deploy Preview succeeded!

Name	Link
🔨 Latest commit	`75895d3`
🔍 Latest deploy log	https://app.netlify.com/sites/tigera/deploys/655639a7ff65d4000846d76d

jsoref · 2023-11-16T07:21:17Z

calico-cloud/_includes/release-notes/_v3.14.0-pre-release-notes.mdx

@@ -19,7 +19,7 @@
 - In BPF dataplane mode, Felix now handles single-block IPAM pools. Previously single-block pools resulted in a collision when programming the dataplane routes. [felix #2245](https://github.com/projectcalico/felix/pull/2245) (@fasaxc)
 - None required [felix #2233](https://github.com/projectcalico/felix/pull/2233) (@tomastigera)
 - None required [felix #2232](https://github.com/projectcalico/felix/pull/2232) (@tomastigera)
- [Openstack] Allow DHCP from the workload, on kernels where rp_filter doesn't already [felix #2231](https://github.com/projectcalico/felix/pull/2231) (@neiljerram)


This correction is based on the author of projectcalico/felix#2231 -- both this incorrect spelling and the correct spelling appeared in the output I was reviewing, and a quick spot check determined this was the incorrect spelling.

jsoref · 2023-11-16T07:22:18Z

calico-cloud/_includes/release-notes/_v3.14.0-pre-release-notes.mdx

- Fix kube-controllers attempting to clean up non-existent node resources [kube-controllers #461](https://github.com/projectcalico/kube-controllers/pull/461) (@fcuello-fudo)
+- Fix kube-controllers attempting to clean up nonexistent node resources [kube-controllers #461](https://github.com/projectcalico/kube-controllers/pull/461) (@fcuello-fudo)


I'm more than happy to drop such changes, they're just among the defaults I use (this is all manual -- I used to feed things to a Google Sheets document, but haven't for the past couple of weeks...).

jsoref · 2023-11-16T07:23:40Z

calico-cloud/get-started/connect/operator-checklist.mdx

-| 5   | intrusion-detection            | TRUE      | FALSE       | FALSE    | 9m49s |
+| 5   | intrusion-detection           | TRUE      | FALSE       | FALSE    | 9m49s |


here's an example of a whitespace correction -- note that I'm well aware that the whitespace isn't relevant, but overall this repository seems to take great care to properly align content (there were a very small handful of cases I ran into from when I initially started that weren't in sync, but with the couple of commits between when I started and when I synced, there were suddenly quite a few).

jsoref · 2023-11-16T07:24:06Z

calico-cloud/image-assurance/scanners/pipeline-scanner.mdx

-   **MacOS**
+   **macOS**


jsoref · 2023-11-16T07:24:34Z

calico-cloud/image-assurance/scanners/pipeline-scanner.mdx

-You can include the CLI scanner in your CI/CD pipelines (for example, Jenkins, Github actions). Ensure the following:
+You can include the CLI scanner in your CI/CD pipelines (for example, Jenkins, GitHub actions). Ensure the following:


grammatically, this should really include a or, but...

jsoref · 2023-11-16T07:24:54Z

calico-cloud/network-policy/beginners/calico-network-policy.mdx

-Because global network policies use **kind: GlobalNetworkPolicy**, they are grouped seperately from **kind: NetworkPolicy**. For example, global network policies will not be returned from `kubectl get networkpolicy.p`, and are rather returned from `kubectl get globalnetworkpolicy`.
+Because global network policies use **kind: GlobalNetworkPolicy**, they are grouped separately from **kind: NetworkPolicy**. For example, global network policies will not be returned from `kubectl get networkpolicy.p`, and are rather returned from `kubectl get globalnetworkpolicy`.


I'm actually somewhat surprised cspell didn't do anything for this...

ctauchen · 2023-11-16T15:35:57Z

Thanks @jsoref. We'll need some time to comb through this, but will be back to you after a while.

calico-enterprise/reference/clis/calicoctl/label.mdx

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

ctauchen · 2024-03-20T16:13:49Z

@jsoref I'm sorry we let this one go stale. We've since brought in another tool, Vale, and have started picking away at these and other inconsistencies.

If you care to address any of those that remain in revised PR, please feel free. For now I'll close this issue.

jsoref added 8 commits November 16, 2023 00:55

spelling: access

cd4950e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: account

e93f888

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: administrators

38c838b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: aggregation

f62a8cc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: anymore

9260177

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: are

786cbda

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: associate

8e68ba9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: calicoctl

de19e7a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref requested a review from a team as a code owner November 16, 2023 07:19

jsoref commented Nov 16, 2023

View reviewed changes

calico-enterprise/reference/clis/calicoctl/label.mdx Outdated Show resolved Hide resolved

jsoref added 15 commits November 16, 2023 10:47

spelling: cannot

5a06b65

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: case-insensitive

c6790fc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: conntrack

ad6bd97

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: detection

3a56250

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: docusaurus

d52ef17

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: downloadable

d109038

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: egress

f4e1611

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: enterprise

c5391cd

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: explicitly

e337244

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: field

3be33a4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: generate

26a2476

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: github

98a4612

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: hotspots

9de0650

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: include

73fbd1a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: individually

18b19f2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 22 commits November 16, 2023 10:47

spelling: kubernetes

66f505e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: loadbalancer

ad204b4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: macos

9c8c779

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: maintenance

dffee68

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: nelljerram

5bdaea8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: nonexistent

0880ab3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: outliers

38961d0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: overridden

c6a288c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: parameters

c925589

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: partner

6e87524

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: retransmitted

3c18f81

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: running

27e3937

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: selectors

38a506c

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: separately

055c9d9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: style

e01a8c5

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: successfully

f10836e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: than

18d87b4

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: typescript

fc3522e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

whitespace: unknown

70a51f2

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: updating

b73d3b0

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: version

c1ebe7e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: you

75895d3

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling branch from cd35b4e to 75895d3 Compare November 16, 2023 15:47

jsoref mentioned this pull request Nov 16, 2023

Spelling projectcalico/calico#8229

Merged

3 tasks

ctauchen closed this Mar 20, 2024

jsoref mentioned this pull request Mar 21, 2024

GH#1102: Fix spelling errors #1383

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH#1102: Fix spelling errors #1103

GH#1102: Fix spelling errors #1103

jsoref commented Nov 16, 2023

jsoref commented Nov 16, 2023

netlify bot commented Nov 16, 2023 •

edited

Loading

netlify bot commented Nov 16, 2023 •

edited

Loading

jsoref Nov 16, 2023

jsoref Nov 16, 2023

jsoref Nov 16, 2023

jsoref Nov 16, 2023

jsoref Nov 16, 2023

jsoref Nov 16, 2023

ctauchen commented Nov 16, 2023

ctauchen commented Mar 20, 2024

		- Fix kube-controllers attempting to clean up non-existent node resources [kube-controllers #461](https://github.com/projectcalico/kube-controllers/pull/461) (@fcuello-fudo)
		- Fix kube-controllers attempting to clean up nonexistent node resources [kube-controllers #461](https://github.com/projectcalico/kube-controllers/pull/461) (@fcuello-fudo)

		\| 5 \| intrusion-detection \| TRUE \| FALSE \| FALSE \| 9m49s \|
		\| 5 \| intrusion-detection \| TRUE \| FALSE \| FALSE \| 9m49s \|

		You can include the CLI scanner in your CI/CD pipelines (for example, Jenkins, Github actions). Ensure the following:
		You can include the CLI scanner in your CI/CD pipelines (for example, Jenkins, GitHub actions). Ensure the following:

		Because global network policies use kind: GlobalNetworkPolicy, they are grouped seperately from kind: NetworkPolicy. For example, global network policies will not be returned from `kubectl get networkpolicy.p`, and are rather returned from `kubectl get globalnetworkpolicy`.
		Because global network policies use kind: GlobalNetworkPolicy, they are grouped separately from kind: NetworkPolicy. For example, global network policies will not be returned from `kubectl get networkpolicy.p`, and are rather returned from `kubectl get globalnetworkpolicy`.

GH#1102: Fix spelling errors #1103

GH#1102: Fix spelling errors #1103

Conversation

jsoref commented Nov 16, 2023

jsoref commented Nov 16, 2023

netlify bot commented Nov 16, 2023 • edited Loading

✅ Deploy Preview for calico-docs-preview-next ready!

netlify bot commented Nov 16, 2023 • edited Loading

👷 Deploy Preview succeeded!

jsoref Nov 16, 2023

Choose a reason for hiding this comment

jsoref Nov 16, 2023

Choose a reason for hiding this comment

jsoref Nov 16, 2023

Choose a reason for hiding this comment

jsoref Nov 16, 2023

Choose a reason for hiding this comment

jsoref Nov 16, 2023

Choose a reason for hiding this comment

jsoref Nov 16, 2023

Choose a reason for hiding this comment

ctauchen commented Nov 16, 2023

ctauchen commented Mar 20, 2024

netlify bot commented Nov 16, 2023 •

edited

Loading

netlify bot commented Nov 16, 2023 •

edited

Loading