Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS#2082] Enterprise version of PR #1373 #1382

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

aaaaaaaalex
Copy link
Contributor

#1373

Product Version(s):
V3.19 EP2

Issue:

Link to docs preview:

SME review:

  • An SME has approved this change.

DOCS review:

  • A member of the docs team has approved this change.

Additional information:

Merge checklist:

  • Deploy preview inspected wherever changes were made
  • Build completed successfully
  • Test have passed

@aaaaaaaalex aaaaaaaalex requested a review from a team as a code owner March 19, 2024 11:21
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for calico-docs-preview-next ready!

Name Link
🔨 Latest commit 0ec9390
🔍 Latest deploy log https://app.netlify.com/sites/calico-docs-preview-next/deploys/65f9754df8402b000861b295
😎 Deploy Preview https://deploy-preview-1382--calico-docs-preview-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 56 (🟢 up 2 from production)
Accessibility: 93 (no change from production)
Best Practices: 92 (no change from production)
SEO: 79 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview succeeded!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ec9390
🔍 Latest deploy log https://app.netlify.com/sites/tigera/deploys/65f9754d024331000892dc3b
😎 Deploy Preview https://deploy-preview-1382--tigera.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 45 (🔴 down 23 from production)
Accessibility: 93 (no change from production)
Best Practices: 83 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ctauchen
Copy link
Collaborator

LGTM. Ready to merge?

@aaaaaaaalex
Copy link
Contributor Author

@ctauchen I dont see the updated text in the deploy preview, did I miss something? 🤔

@aaaaaaaalex
Copy link
Contributor Author

sample link where I dont see the updated text

@ctauchen
Copy link
Collaborator

ctauchen commented Mar 20, 2024

Seems to be there. See https://deploy-preview-1382--calico-docs-preview-next.netlify.app/calico-enterprise/next/reference/component-resources/configuration#enabling-policy-setup-timeout

This is the version next preview. You were looking in the production preview, which doesn't build upcoming versions.

@aaaaaaaalex
Copy link
Contributor Author

Ah I see, thanks @ctauchen, happy to merge in that case

@ctauchen ctauchen merged commit 2c910f2 into tigera:main Mar 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants