-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2075: Operator IP pool management docs #1390
Conversation
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview succeeded!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@caseydavenport You mentioned some other docs work we should consider for the multiple ip pools work. How to add ip pools, how to disable operator management of ip pools, considerations for upgrades. Are you planning to handle those separately, or has the scope changed? |
I believe the considerations for upgrades are no longer necessary, as I have adjusted the way the feature behaves such that there are no extra steps required on upgrade.
I think these are good to have and would like to add them to this PR (or a follow on). I am not sure the right place to put them though, so would be happy to hear any recommendations! |
I'd imagine this could work as a single page in here: https://docs.tigera.io/calico/latest/networking/ipam/. Something along the lines of:
|
@ctauchen I've pushed some new content to this PR that I'd like your eyes on :) If it looks good, I think it should also be added to the unrelease enterprise documentation - should I simply copy the changes there? |
@ctauchen did you get a chance to take a look at this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, mostly formatting with a few line edits. Let me take a final look after you make changes. When these are all good, we can get this all copied to /calico-enterprise/
to make it in for CE 3.19 EP2.
Co-authored-by: Christopher Tauchen <tauchen@gmail.com>
Co-authored-by: Christopher Tauchen <tauchen@gmail.com>
8f92e3e
to
118c4ca
Compare
@ctauchen thanks for the review! Think I got all of them now |
Thanks for the fixes @caseydavenport. You can update the same docs in ./calico-enterprise and we can get this merged. Thanks! |
Thanks @ctauchen - updated enterprise as well. |
118c4ca
to
82c88f2
Compare
@ctauchen shoot, looks like I overwrite the other fix commits. Hold off on reviewing again. |
82c88f2
to
118c4ca
Compare
@ctauchen OK, I think it should be good to go now. |
LGTM |
Product Version(s):
Calico v3.28 / Enterprise v3.19
Issue:
Link to docs preview:
SME review:
DOCS review:
Additional information:
Merge checklist: