extend timeout to avoid not ready containers #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmjd
reviewed
May 27, 2021
pkg/render/node.go
Outdated
| @@ -1296,6 +1296,9 @@ func (c *nodeComponent) nodeLivenessReadinessProbes() (*v1.Probe, *v1.Probe) { | |||
| } | |||
| rp := &v1.Probe{ | |||
| Handler: v1.Handler{Exec: &v1.ExecAction{Command: readinessCmd}}, | |||
| //period is default but timeout is half to account for some slow machines | |||
There was a problem hiding this comment.
I'd prefer this explain why we're not using the default but with a caveat of keeping it less than the period. Maybe something like
Set the TimeoutSeconds greater than the default of 1 to allow additional time on loaded nodes. Keep this time less than the PeriodSeconds.
|
Also it looks like you'll need to fix up some tests. I don't know if you can see the test output but if not you can hopefully run |
Fixing CI for Timeout change
tmjd
added a commit
to tmjd/operator
that referenced
this pull request
May 28, 2021
* extend timeout to avoid not ready containers that are slow but otherwise fine Co-authored-by: Erik Stidham <erik@tigera.io>
tmjd
added a commit
that referenced
this pull request
May 28, 2021
extend timeout to avoid not ready containers (pick #1325 r1.17)
tmjd
added a commit
to tmjd/operator
that referenced
this pull request
Jun 1, 2021
* extend timeout to avoid not ready containers that are slow but otherwise fine Co-authored-by: Erik Stidham <erik@tigera.io>
tmjd
added a commit
that referenced
this pull request
Jun 1, 2021
extend timeout to avoid not ready containers (pick #1325 r1.18)
|
Fixes #1324 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This happens when machines are slow/busy. calico-node containers show as unready.
See issue #1324 but readiness probe timeout seems to be abit short.
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.