Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EV-4854] Adding X-Frames-Options DENY header for Kibana #3516

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

vikastigera
Copy link
Contributor

Description

Changes done to add X-Frames-Options DENY header for Kibana requests.
https://tigera.atlassian.net/browse/EV-4854

TESTING

Screenshot from 2024-09-23 13-15-03

For PR author

  • Tests for change.
  • If changing pkg/apis/, run make gen-files
  • If changing versions, run make gen-versions

For PR reviewers

A note for code reviewers - all pull requests must have the following:

  • Milestone set according to targeted release.
  • Appropriate labels:
    • kind/bug if this is a bugfix.
    • kind/enhancement if this is a a new feature.
    • enterprise if this PR applies to Calico Enterprise only.

Changes done to add X-Frames-Options DENY header for Kibana requests.
Copy link
Member

@rene-dekker rene-dekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rene-dekker rene-dekker merged commit 06fc604 into tigera:master Sep 23, 2024
5 checks passed
vikastigera added a commit to vikastigera/operator that referenced this pull request Sep 25, 2024
Changes done to add X-Frames-Options DENY header for Kibana requests.
vikastigera added a commit to vikastigera/operator that referenced this pull request Sep 25, 2024
Changes done to add X-Frames-Options DENY header for Kibana requests.
rene-dekker pushed a commit that referenced this pull request Oct 1, 2024
Changes done to add X-Frames-Options DENY header for Kibana requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants