Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(comment) #229

Merged
merged 4 commits into from
May 23, 2024
Merged

tests(comment) #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
044fbe6
tests(comment)
parkererickson-tg May 23, 2024
daacf35
remove component of edge test
parkererickson-tg May 23, 2024
4e98319
fix(_delete): change default param on resKey
parkererickson-tg May 23, 2024
af2127c
fix(edge tests): remove comments
parkererickson-tg May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyTigerGraph/pyTigerGraphBase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ def _put(self, url: str, authMode: str = "token", data = None, resKey=None, json

return res

def _delete(self, url: str, authMode: str = "token", data: dict = None, resKey=None, jsonData=False) -> Union[dict, list]:
def _delete(self, url: str, authMode: str = "token", data: dict = None, resKey="results", jsonData=False) -> Union[dict, list]:
"""Generic DELETE method.

Args:
Expand Down
2 changes: 1 addition & 1 deletion pyTigerGraph/pyTigerGraphQuery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,7 @@ def dropQueryDescription(self, queryName: str, dropParamDescriptions: bool = Tru
else:
params = {"queries": [queryName]}
print(params)
res = self._delete(self.gsUrl+"/gsqlserver/gsql/description?graph="+self.graphname, authMode="pwd", data=params, jsonData=True)
res = self._delete(self.gsUrl+"/gsqlserver/gsql/description?graph="+self.graphname, authMode="pwd", data=params, jsonData=True, resKey=None)

if logger.level == logging.DEBUG:
logger.debug("return: " + str(res))
Expand Down