Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Negative part wasn't always handled, so expressions like
(1 << 256) - 1
behaved incorrectly.The result of the subtraction contained 5 64-bit numbers, but only first one was correct, i.e. had 0xffff... value. Next 3 parts were all 0's, and the last one was 1.
The fix is simple - just add the negative part of the operand if it was negative initially.
Initial behavior was kinda like unsigned addition, but
if (negA)
check ruined everything anyways because of incorrect addition of negative part. There's possibly an additional overload needed to have correct unsigned behavior.