Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaffold Laravel Elixir integration when initializing new sites #10

Merged
merged 6 commits into from
Jan 8, 2016

Conversation

adamwathan
Copy link
Contributor

Still a work in progress, but currently:

  • Scaffolds default package.json
  • Scaffolds default gulpfile.json
  • Scaffolds default .gitignore
  • Scaffolds basic master layout and index template
  • Scaffolds empty main.scss (and main.css so fresh sites have no console errors)
  • gulp watch watches for all changes in the source folder and recompiles the site if anything changes

Nice to haves:

  • Currently updating an asset file (like main.scss) triggers two recompiles because the Sass file changes, which triggers the CSS file to change. It would be nice to avoid this, but it might only be possible by moving precompiled assets out of the source folder.
  • It would be kind of nice to not compile assets into the source folder, and instead only compile them into the build folders, so no compiled assets end up in the raw source files.
  • Would be nice to put together a command like jigsaw serve that starts a PHP server pointed at build_local and starts gulp watch.
  • The gulp file currently expects Jigsaw to be installed globally, would be nice to have it try for a local one first, probably can do this with bash no problem.
  • The jigsaw build command that Gulp runs is hard coded, so you can't disable pretty URLs without editing the gulp file. This may or may not be worth addressing, it's pretty easy to edit that file yourself.

@adamwathan
Copy link
Contributor Author

@mattstauffer Thinking about where the assets should be compiled to, right now they land in {your-build-folder}/assets/css/main.css. Wondering if it might be better to get rid of the assets folder and move those subfolders to top level, so {your-build-folder}/css/main.css. Assets would still live in _assets before compiling, but not get moved to assets/{asset-type} afterwards.

What do you think is more common or would be preferred?

@mattstauffer
Copy link
Member

@adamwathan I think not requiring the /assets on the dist is great. It's 6 of one half dozen of the other; I guess someone could have a /css or /js directory that they would want content-wise (mysite.com/css/article-about-css-here) but I'm not too worried about it.

@adamwathan
Copy link
Contributor Author

@mattstauffer just tried it, it still works even if you do that anyways, keeps all the files. I think I'll default it to jam everything in the root, so insanely easy to change in the gulpfile if people want to do that.

adamwathan added a commit that referenced this pull request Jan 8, 2016
Scaffold Laravel Elixir integration when initializing new sites
@adamwathan adamwathan merged commit 99390b7 into master Jan 8, 2016
@adamwathan adamwathan deleted the aw-elixir-integration branch January 8, 2016 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants