Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of skills that show on a module to a max of 5 #477

Closed
2 tasks done
tammytee opened this issue Sep 23, 2022 · 3 comments · Fixed by #485
Closed
2 tasks done

Limit the number of skills that show on a module to a max of 5 #477

tammytee opened this issue Sep 23, 2022 · 3 comments · Fixed by #485
Assignees
Labels

Comments

@tammytee
Copy link
Contributor

tammytee commented Sep 23, 2022

Summary

Todo

  • Add a limit to the number of skills a module can have/show on a module
  • Audit the existing resources

Modules to audit

  • Laravel Basics For WordPress Developers
  • Basic Testing (has 5 exactly)
  • Basic JavaScript
  • Laravel Basics
  • Beginning PHP

Idea

Rather than removing the extra skills, we could make it so the user sees a small + 3 more bubble or something similar that can be clicked to see the remaining skills. We may also want to consider making them smaller so they don't take up so much space?

Current Example

image

@tammytee tammytee added the good first issue Good for newcomers label Sep 27, 2022
@LubosGangster
Copy link

Hi,

i would like to help with that issue. Can you assign it to me ?

@tammytee
Copy link
Contributor Author

tammytee commented Oct 3, 2022

Hi @LubosGangster!

Thanks for your help 😄. For this issue, we'd like to limit the number of skills shown on a module by default to prevent the "Overview" and "Skills" sections from getting too big. The issue title mentions a max of five, but I think this would actually work great if it's limited to four, with the fifth badge being a button users can click to see the remaining skills.

The summary above lists all of the modules that currently have 5 or more skills.

Here are some acceptance criteria for this issue:

  • display four skills on a module detail page by default
  • if a module has more than four skills, add a fifth badge that will show/hide the remaining skills
  • the fifth badge should show the number of skills that are hidden

Example:
image

Here are additional details on how to contribute to this repo. Happy coding 😃!

@LubosGangster
Copy link

hi @tammytee ,

i created PR -> #485

Can you review it ?

@tammytee tammytee linked a pull request Oct 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants