Show more skills #485
Merged
Show more skills #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
tammytee
suggested changes
Oct 11, 2022
There was a problem hiding this comment.
Hi @LubosGangster!
Thanks for working on this. I wonder if we might be able to take a much simpler approach to achieve this by using AlpineJS (already included in the codebase) to show/hide extra skills right on the frontend.
Would you mind looking into that and let me know what you think? Thanks!
|
Hi @LubosGangster - is there anything I can help you with here? |
added 2 commits
October 23, 2022 16:33
|
Hi, @tammytee , yes you are right, thanks for the review. I have not heard of alpine js until now. I repaired it. |
tammytee
approved these changes
Oct 25, 2022
tammytee
reviewed
Oct 25, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry it took me so long, couldn't done it sooner than today, cause i was busy