-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show more skills #485
Show more skills #485
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LubosGangster!
Thanks for working on this. I wonder if we might be able to take a much simpler approach to achieve this by using AlpineJS (already included in the codebase) to show/hide extra skills right on the frontend.
Would you mind looking into that and let me know what you think? Thanks!
Hi @LubosGangster - is there anything I can help you with here? |
Hi, @tammytee , yes you are right, thanks for the review. I have not heard of alpine js until now. I repaired it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉 - I just included two small suggestions to fix code indentation but this looks and works great otherwise! Thank you!
sorry it took me so long, couldn't done it sooner than today, cause i was busy