-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store preferred language for resources (closes #93) #103
Conversation
Signed-off-by: Tonko Mulder <tonko@tonkomulder.nl>
Signed-off-by: Tonko Mulder <tonko@tonkomulder.nl>
Signed-off-by: Tonko Mulder <tonko@tonkomulder.nl>
Hitting pause for the night, but just in case anyone else takes a look, I moved preferences to be a JSON column on the user, and added a convenience method on the user named It functions like the global However, there's one big difference; it has defaults pre-set for each key, and you can only set keys that are in the pre-set list of preferences. So as we add a preference, we'll add its key, it's possible options, and its default into that list. |
I have decided to keep the resource switcher in Vue for now because it's the cleanest way to POST to the endpoint making the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty to go through this pr because I noticed it had "a lot" of files.
Commented on some files with questions and suggestions. I also have a question about the public app.css
and app.js
.
Should those files be included to git? Reason is that it feels really weird to me to have "compiled" files in git.
I would also suggest to try to keep the pr a little bit smaller so it is more easy to go through the changes that were made.
Yep. |
Allowing a few todo's in because they relate to work addressed in #115 |
Replaces/continues #94, closes #93 -- moved modifications to that PR into here so it could be a branch I have access to.
@Treggats, I started work on revising your PR. I paused when I saw that you were storing the user preference as an int; I'd rather we store them as strings. I'm going to pause for now, but next steps as I see it:
PreferenceController
@todo
s I introduced