Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making content translatable on learning page and translating it to sp… #31

Merged
merged 2 commits into from
Aug 12, 2019
Merged

Making content translatable on learning page and translating it to sp… #31

merged 2 commits into from
Aug 12, 2019

Conversation

claudiamp
Copy link

I have made the learning page translatable to other languages and added links to Spanish resources. This would contribute to issue #26.

There are packages and other solutions that can make the site translatable, but I went for the simplest option that would maintain the use of the learn.php file to add the resources.

For the content on the site, I have used the localization feature of Laravel (https://laravel.com/docs/5.8/localization). For the learning PHP file, I edited the route file so we could pass the language as a parameter and choose the localized learn.php file.

@mattstauffer
Copy link
Member

@claudiamp Wow, thank you so much for your work on this!

I want to think about it a bit, to make sure that when I make changes in the future to the base site language I have the ability to do so without having to wait for a translator, and to make sure that content that we have in one language but not the the others can fall through.

However, I think we can likely make all those changes more when we move the content into databases (which is super likely), so let's just go with this for now and focus on how best to add a translation link for now, and tweak it as we go.

Thank you so much for your time on this!

@mattstauffer mattstauffer merged commit 66aca2e into tighten:master Aug 12, 2019
@mattstauffer
Copy link
Member

(Just kidding, you already added the link. Great work!!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants