Bugfix: Unable to serialize multi-type collections #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update HasParent.php to fix collection serialization. Currently Parental creates unserializable Eloquent collections resulting in an error when pushing the colleciton to queue Queueing collections with multiple model types is not supported. I merged a framework request to create this callback on the model to circumvent the issue. laravel/framework#44272 This should fix the serialization error.
Changed requirement to framework version v9.32.
…zation Fix collection serialization
Smoggert
changed the title
Invalid json
driftingly
reviewed
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix can be merged once the next framework version goes live.
Currently the fix in the laravel framework is on 9.x (upcoming 9.32.0)
laravel/framework#44272
This fixes an issue with serializing collections with multiple different models.
This issue occurs when queueing an eloquent collection
( and in some less important cases like livewire abusing the serialization logic during mounting of a component. )