Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register observers on children through parent #26

Merged
merged 2 commits into from
Jan 10, 2019
Merged

Register observers on children through parent #26

merged 2 commits into from
Jan 10, 2019

Conversation

wfeller
Copy link
Contributor

@wfeller wfeller commented Dec 21, 2018

Takes care of #23

@ferrl
Copy link

ferrl commented Dec 28, 2018

Hello, @wfeller!

WDYT about instead of changing the behaviour of the observe method, you add this same logic you implemented here directly into the registerModelEvent method?

This way it will work for all event binding methods (like creating, updating, etc).

@wfeller
Copy link
Contributor Author

wfeller commented Jan 4, 2019

Hi @ferrl,
Good idea, I've updated my fix.
Thanks!

ferrl
ferrl approved these changes Jan 7, 2019
View reviewed changes
Copy link

@ferrl ferrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@calebporzio
Copy link
Contributor

Really nice PR - thanks for writing tests.

@calebporzio calebporzio merged commit 4eafd3d into tighten:master Jan 10, 2019
@kbond kbond mentioned this pull request Feb 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferrl ferrl ferrl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wfeller @ferrl @calebporzio