Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable paths in config #287

Closed
ecrmnn opened this issue Apr 8, 2022 · 5 comments · Fixed by #288
Closed

Customizable paths in config #287

ecrmnn opened this issue Apr 8, 2022 · 5 comments · Fixed by #288

Comments

@ecrmnn
Copy link

ecrmnn commented Apr 8, 2022

Hey!
We use TLint in multiple projects and love it! Great job! 👏

In some of our apps we have a different app structure.
We might have "Modules" both the root directory or within the app directory.
These "Modules" contains controllers and other logic.

We're unable to lint these files due to how the path is being set.
E.g. LintsControllers, https://github.com/tighten/tlint/blob/main/src/Linters/Concerns/LintsControllers.php

How could TLint allow a preset or config to customize paths that override traits?
Is this even of interest to add to the package?
We would be happy to make a PR, but how would you like it solved?
Or should we simply fork it and roll our own solution?

@driftingly
Copy link
Member

@ecrmnn will PR #288 work for you?

@ecrmnn
Copy link
Author

ecrmnn commented Apr 25, 2022

Thanks @driftingly

I'm pretty sure this solves our problem. Thanks a lot!

We've written a few custom rules as well, do you think it's best to keep them in our own separate package or would you like us to make PRs to TLint?

@driftingly
Copy link
Member

@ecrmnn This has been tagged v6.3.0.

For PRs, yes please, PRs are welcomed. Just keep in mind they may not get merged in (the tool is fairly opinionated), but it would be helpful to see what extra functionality you needed. There's a bit of a shift coming with the 7.0 release. This tool will leave a lot of sniffing/formatting to another tool where that tool is able: #284

@ecrmnn
Copy link
Author

ecrmnn commented Apr 26, 2022

We're using TLint in combination with PHP CS Fixer since we feel it lacks important rules. Just take NoCompact as an example, there isn't any equivalent in PHP CS Fixer as I know of.

What are you planning on removing?

Would be good to know so we don't invest time in a package that is going away or changed drastically.

@driftingly
Copy link
Member

We are removing lints and formatters that are covered by those other tools (Sniffer and Fixer) and focusing on what those tools cannot do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants